Skip to content

Conversation

@TorMFinn
Copy link

This change adds the nv-codec-headers package as a build dependency to gst-plugins-bad1 enabling the build of the nvcodec plugins.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revision needs to be incremented

@TorMFinn
Copy link
Author

Thanks! I have bumped the revision and fixed a trailing whitespace

@zlice
Copy link
Contributor

zlice commented Jan 28, 2025

fyi, update here #53936

@TorMFinn
Copy link
Author

fyi, update here #53936

Then I assume the correct way to merge this would be to wait till 1.24.11 gets merged and then rebase my branch?

@zlice
Copy link
Contributor

zlice commented Jan 29, 2025

just a heads up. similar thing happened with blender a bit back and theyre in limbo

@classabbyamp
Copy link
Member

it's not in "limbo", both PRs had unaddressed feedback

@classabbyamp classabbyamp merged commit 7e9cdec into void-linux:master Feb 11, 2025
8 checks passed
@TorMFinn
Copy link
Author

@classabbyamp I see this got merged, thanks! :) However something seems to have gone wrong. When I install the package from the official repository the plugin is still not available. The logs in this pull request shows that it is built and stripped but for some reason it is not in the repo yet even though the package I install is with the version and revision from this pull request.

If you check the build logs for x86_64 in this pull request on line 2686 it says:

Stripped library: /usr/lib/gstreamer-1.0/libgstnvcodec.so

indicating that it did in fact get built as expected.

If we do xbps-query -Rf gst-plugins-bad1 the package contents does not list libgstnvcodec.so
If I build this package locally the plugin is installed.

@zlice
Copy link
Contributor

zlice commented Feb 19, 2025

the last 2 revbumps have been 2, which dropped the rev update from this

000700b

7e9cdec

revmissing

@classabbyamp
Copy link
Member

0818f46

@TorMFinn
Copy link
Author

Perfect! It's there now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants